<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I just realized where this thread was (had previously only been CCed) so thought I'd reproduce my comments here for posterity.<blockquote type="cite"><div><div></div><div>I just wanted to drop you a note as to the location of my notes on spatial filters: <a href="http://projects.opengeo.org/geoext/wiki/FilterBuilder">http://projects.opengeo.org/geoext/wiki/FilterBuilder</a></div><div><br></div><div>The big differences from what I saw of yours are that I allow attribute and spatial conditions to be mixed and I group the drawing/editing tools with each condition to allow for multiple spatial filters, though I'm not sure how common either of those use cases are.</div><div><br></div><div>It's still a pretty rough draft, so please let me know if you have any thoughts or any clear use cases you are trying to solve for.</div></div></blockquote>In response to your comments below, moving the vector drawing tools out of the top bar and adjacent to the condition adheres more closely to our convention of keeping the parameters closely tied to each condition and allows us to create multiple spatial features (whether or not that is something we actually want is a different question). It's true that removing an explicit "add spatial filter" option means fewer clicks, but I wonder if it means giving up on clarity as well.<div><br></div><div>Thanks again for all your work on this, don't hesitate to let me know if you have any ideas or would like me to mock up any other approaches.<br><div><div><br><div><div apple-content-edited="true"><div><div><div><div><div><div><div><div>-- <br>Rolando Peñate</div><div>Design Lead</div><div>OpenGeo - <a href="http://opengeo.org">http://opengeo.org</a></div><div><br></div><div>PS - The point/line/polygon icons in my mockup differ from those found in OpenLayers. If you're interested in using them they're part of the GeoSilk set: <a href="http://projects.opengeo.org/geosilk/wiki/#VectorIcons">http://projects.opengeo.org/geosilk/wiki/#VectorIcons</a></div></div></div></div></div></div></div></div> </div><br><div><div>On Aug 6, 2009, at 11:17 AM, François Van Der Biest wrote:</div><br><blockquote type="cite"><div>Great !<br><br>Here's how I envision things ...<br>(the attached screenshot may help)<br><br>If the allowSpatial option is set to true on the FilterBuilder, a top<br>toolbar is added.<br>This toolbar has 3 GeoExt.Action, configured with drawFeature controls<br>(toggle buttons).<br><br>Each time a feature is added, a SpatialFilterPanel is added as a child<br>to the FilterBuilder (same behavior as currently with FilterPanels).<br><br>A SpatialFilterPanel has a reference to the drawn feature, and enables<br>its modification via a "modify" button (we take advantage of the newly<br>introduced standalone option in the modifyfeature control). This<br>button shares the same toggleGroup as those from the top toolbar.<br>A SpatialFilterPanel also has a combobox with the different kinds of<br>spatial filters preconfigured.<br><br>When we first talked about this with Eric, we were thinking of adding<br>a "add spatial filter" button on the bottom toolbar, which would<br>activate/show the top toolbar and add a SpatialFilterPanel panel. I<br>finally chose the option I described above because I think it enables<br>the user to do more things with less clicks.<br><br>What would be your option on that ?<br>Thank's,<br>F.<br><br>On Thu, Aug 6, 2009 at 4:42 PM, Chris Holmes<<a href="mailto:cholmes@opengeo.org">cholmes@opengeo.org</a>> wrote:<br><blockquote type="cite">That's awesome, the lack of spatial filters in the filter builder is<br></blockquote><blockquote type="cite">definitely a major hole right now. If you need any help with the<br></blockquote><blockquote type="cite">interaction design we'd be happy to have our designer (cced) take a look.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">As for patches, for now just create a ticket on<br></blockquote><blockquote type="cite"><a href="http://projects.opengeo.org/styler">http://projects.opengeo.org/styler</a> and attach a patch there.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">And we're looking for funding to incorporate styler as geoext components and<br></blockquote><blockquote type="cite">extensions (for the REST interaction with geoserver which probably isn't<br></blockquote><blockquote type="cite">appropriate for geoext core as it's app specific). If you guys can help out<br></blockquote><blockquote type="cite">with that before we get funding we can point you at the tickets and do code<br></blockquote><blockquote type="cite">reviews.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Chris<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">François Van Der Biest wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">FYI, we're currently working on the FilterBuilder to add the ability to<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">create spatial filters.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Cheers,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">F.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">On Tue, Aug 4, 2009 at 6:42 PM, Eric Lemoine <<a href="mailto:eric.lemoine@camptocamp.com">eric.lemoine@camptocamp.com</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><<a href="mailto:eric.lemoine@camptocamp.com">mailto:eric.lemoine@camptocamp.com</a>>> wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Hi Tim<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> We've started using elements of the styler. We have a few patches that<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> we'd like to contribute. Do you know where we should send them?<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Thanks,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> --<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Eric Lemoine<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Camptocamp France SAS<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Savoie Technolac, BP 352<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> 73377 Le Bourget du Lac, Cedex<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Tel : 00 33 4 79 44 44 96<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Mail : eric.lemoine@camptocamp.com <<a href="mailto:eric.lemoine@camptocamp.com">mailto:eric.lemoine@camptocamp.com</a>><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> <a href="http://www.camptocamp.com">http://www.camptocamp.com</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> _______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Users mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> Users@geoext.org <<a href="mailto:Users@geoext.org">mailto:Users@geoext.org</a>><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> <a href="http://www.geoext.org/cgi-bin/mailman/listinfo/users">http://www.geoext.org/cgi-bin/mailman/listinfo/users</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">------------------------------------------------------------------------<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">_______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Users mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:Users@geoext.org">Users@geoext.org</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://www.geoext.org/cgi-bin/mailman/listinfo/users">http://www.geoext.org/cgi-bin/mailman/listinfo/users</a><br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">--<br></blockquote><blockquote type="cite">Chris Holmes<br></blockquote><blockquote type="cite">OpenGeo - <a href="http://opengeo.org">http://opengeo.org</a><br></blockquote><blockquote type="cite">Expert service straight from the developers.<br></blockquote><blockquote type="cite"><br></blockquote><span id="cid:701EAE1D-3DB6-46EB-ABC4-BD66FD9F1CEB@limewire.int"><Screenshot-1.png></span></div></blockquote></div><br></div></div></div></div></body></html>