<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Matt,<br>
<br>
<a class="moz-txt-link-freetext" href="http://trac.geoext.org/ticket/412#comment:3">http://trac.geoext.org/ticket/412#comment:3</a><br>
<br>
See the patch with the according changes your proposed. It looks
cleaner to me. What do you think ?<br>
<br>
Alexandre<br>
<br>
<br>
On 11-03-23 07:57 AM, Alexandre Dube wrote:
<blockquote cite="mid:4D89E012.9010408@mapgears.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Matt,<br>
<br>
You suggestion makes sense to me. I'll make the according
changes this morning and report back.<br>
<br>
Thanks a lot for your review,<br>
<br>
Alexandre<br>
<br>
<br>
On 11-03-22 04:48 PM, Matt Priour wrote:
<blockquote cite="mid:F2B08AEC49EF42E1BAFBC1B33FFDB32E@Lenovo"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta content="MSHTML 6.00.6002.18357" name="GENERATOR">
<div><font face="Arial" size="2">Looking at the ticket &
patch, I think that code is always going to be kind of ugly
when you allow people to mix strings and objects in
configuration like that.</font></div>
<div><font face="Arial" size="2">I think specifying either a
pure string</font></div>
<div><font face="Arial" size="2">ex: "BBOX"</font></div>
<div><font face="Arial" size="2">or a pure object</font></div>
<div><font face="Arial" size="2">ex: {type:"BBOX",ratio:1.25}</font></div>
<div> </div>
<div><font face="Arial" size="2">would be easier to deal with
and would better match with the other configuration object
conventions used in ExtJS, OL, & GeoExt</font></div>
<div> </div>
<div><font face="Arial" size="2">However people could mix the 2
different configuration specification types in the
strategies array:</font></div>
<div><font face="Arial" size="2">ex:</font></div>
<div><font face="Arial" size="2">strategies : [ "Save",
{type:"BBOX",ratio:1.25} ]</font></div>
<div> </div>
<div><font face="Arial" size="2">Thanks for getting this
started.</font></div>
<div> </div>
<div><font face="Arial" size="2">Matt Priour</font></div>
<div><font face="Arial" size="2">Kestrel Computer Consulting</font></div>
<div style="font: 10pt Tahoma;">
<div><br>
</div>
<div style="background: none repeat scroll 0% 0% rgb(245, 245,
245);">
<div style=""><b>From:</b> <a moz-do-not-send="true"
title="adube@mapgears.com"
href="mailto:adube@mapgears.com">Alexandre Dube</a> </div>
<div><b>Sent:</b> Tuesday, March 22, 2011 3:02 PM</div>
<div><b>To:</b> <a moz-do-not-send="true"
title="mpriour@kestrelcomputer.com"
href="mailto:mpriour@kestrelcomputer.com">Matt Priour</a>
</div>
<div><b>Cc:</b> <a moz-do-not-send="true"
title="eric.lemoine@camptocamp.com"
href="mailto:eric.lemoine@camptocamp.com">Eric Lemoine</a>
; <a moz-do-not-send="true" title="users@geoext.org"
href="mailto:users@geoext.org">GeoEXT Users</a> </div>
<div><b>Subject:</b> Re: [Users] WFSCapabilitiesReader -
default layer strategies</div>
</div>
</div>
<div><br>
</div>
Hi,<br>
<br>
An update about this thread. I created a ticket : <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://trac.geoext.org/ticket/412">http://trac.geoext.org/ticket/412</a><br>
<br>
It contains a patch that fixes the issue. I don't really like
how I made it (it could have been better, I think) and it's
missing test units. Could someone give me a comment/hint about
it, please ?<br>
<br>
Kind regards,<br>
<br>
Alexandre<br>
<br>
<br>
On 11-02-15 09:27 AM, Matt Priour wrote:
<blockquote cite="mid:9D6A358FC66C431DBAB66643C28037D9@Lenovo"
type="cite">
<meta content="MSHTML 6.00.6002.18357" name="GENERATOR">
<div><font face="Arial" size="2">+1 on the option to use the
short strategy name string with an options object.</font></div>
<div><font face="Arial" size="2">We could implement this
immediately in GeoExt when creating layers from the
capabilities store and the layerOptions, if there is not
equal support for that syntax directly in OL.</font></div>
<div> </div>
<div><font face="Arial" size="2">I've also come across this
issue and ended up solving it by listening to 'add' event
on the layer store and then modifying options on the
layers accordingly. I would much prefer the ability to set
the defaults in the layerOptions rather than having to
modify them after creation.</font></div>
<div> </div>
<div><font face="Arial" size="2">Matt Priour</font></div>
<div><font face="Arial" size="2">Kestrel Computer Consulting</font></div>
<div><br>
</div>
<div style="font: 10pt Tahoma;">
<div style="background: none repeat scroll 0% 0% rgb(245,
245, 245);">
<div><b>From:</b> <a title="eric.lemoine@camptocamp.com"
href="mailto:eric.lemoine@camptocamp.com"
moz-do-not-send="true">Eric Lemoine</a> </div>
<div><b>Sent:</b> Tuesday, February 15, 2011 7:51 AM</div>
<div><b>To:</b> <a title="adube@mapgears.com"
href="mailto:adube@mapgears.com"
moz-do-not-send="true">Alexandre Dube</a> </div>
<div><b>Cc:</b> <a title="users@geoext.org"
href="mailto:users@geoext.org" moz-do-not-send="true">GeoEXT
Users</a> </div>
<div><b>Subject:</b> Re: [Users] WFSCapabilitiesReader -
default layer strategies</div>
</div>
</div>
<div><br>
</div>
> What if we started supporting this :<br>
> var layer = new OpenLayers.Layer.Vector("layer", {<br>
> protocol: ...,<br>
> strategies: ["OpenLayers.Strategy.BBOX"]<br>
> });<br>
><br>
> and this too :<br>
> var layer = new OpenLayers.Layer.Vector("layer", {<br>
> protocol: ...,<br>
> strategies: [{"OpenLayers.Strategy.BBOX": {ratio: 1}}]<br>
> });<br>
<br>
That was my suggestion. And I think {"BBOX"} and {"BBOX":
{ratio: 1}}<br>
could also be supported.<br>
<br>
<br>
<br>
-- <br>
Eric Lemoine<br>
<br>
Camptocamp France SAS<br>
Savoie Technolac, BP 352<br>
73377 Le Bourget du Lac, Cedex<br>
<br>
Tel : 00 33 4 79 44 44 96<br>
Mail : <a href="mailto:eric.lemoine@camptocamp.com"
moz-do-not-send="true">eric.lemoine@camptocamp.com</a><br>
<a href="http://www.camptocamp.com" moz-do-not-send="true">http://www.camptocamp.com</a><br>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@geoext.org" moz-do-not-send="true">Users@geoext.org</a><br>
<a href="http://www.geoext.org/cgi-bin/mailman/listinfo/users"
moz-do-not-send="true">http://www.geoext.org/cgi-bin/mailman/listinfo/users</a><br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Alexandre Dubé
Mapgears
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="http://www.mapgears.com">www.mapgears.com</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Alexandre Dubé
Mapgears
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="http://www.mapgears.com">www.mapgears.com</a>
</pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Users@geoext.org">Users@geoext.org</a>
<a class="moz-txt-link-freetext" href="http://www.geoext.org/cgi-bin/mailman/listinfo/users">http://www.geoext.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Alexandre Dubé
Mapgears
<a class="moz-txt-link-abbreviated" href="http://www.mapgears.com">www.mapgears.com</a>
</pre>
</body>
</html>