[Commits] r345 - in core/trunk/geoext: lib/GeoExt/widgets tests/lib/GeoExt/widgets

commits at geoext.org commits at geoext.org
Fri Apr 3 18:06:15 CEST 2009


Author: tschaub
Date: 2009-04-03 18:06:15 +0200 (Fri, 03 Apr 2009)
New Revision: 345

Modified:
   core/trunk/geoext/lib/GeoExt/widgets/MapPanel.js
   core/trunk/geoext/tests/lib/GeoExt/widgets/MapPanel.html
Log:
If an OpenLayers.Map object is not provided to the MapPanel constructor, we create one with allOverlays set to true.  To have the MapPanel create a map with allOverlays false, send a map config object with {allOverlays: true}.  r=ahocevar (closes #35)

Modified: core/trunk/geoext/lib/GeoExt/widgets/MapPanel.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/widgets/MapPanel.js	2009-04-03 15:05:44 UTC (rev 344)
+++ core/trunk/geoext/lib/GeoExt/widgets/MapPanel.js	2009-04-03 16:06:15 UTC (rev 345)
@@ -98,7 +98,9 @@
      */
     initComponent: function(){
         if(!(this.map instanceof OpenLayers.Map)) {
-            this.map = new OpenLayers.Map(this.map);
+            this.map = new OpenLayers.Map(
+                Ext.applyIf(this.map || {}, {allOverlays: true})
+            );
         }
         var layers = this.layers;
         if(!layers || layers instanceof Array) {

Modified: core/trunk/geoext/tests/lib/GeoExt/widgets/MapPanel.html
===================================================================
--- core/trunk/geoext/tests/lib/GeoExt/widgets/MapPanel.html	2009-04-03 15:05:44 UTC (rev 344)
+++ core/trunk/geoext/tests/lib/GeoExt/widgets/MapPanel.html	2009-04-03 16:06:15 UTC (rev 345)
@@ -41,6 +41,32 @@
             t.eq(mapPanel.map.getCenter().toString(), "lon=5,lat=45", "Map center set correctly");
             t.eq(mapPanel.map.getZoom(), 4, "Zoom set correctly");
         }
+        
+        function test_allOverlays(t) {
+            t.plan(3);
+            var map, panel;
+            
+            map = new OpenLayers.Map();
+            panel = new GeoExt.MapPanel({
+                map: map
+            });
+            t.eq(panel.map.allOverlays, false, "allOverlays is not set if map is provided to panel");
+            panel.destroy();
+            
+            panel = new GeoExt.MapPanel({
+            });
+            t.eq(panel.map.allOverlays, true, "allOverlays set to true if no map is provided to panel");
+            panel.destroy();
+            
+            panel = new GeoExt.MapPanel({
+                map: {
+                    units: "meters"
+                }
+            });
+            t.eq(panel.map.allOverlays, true, "allOverlays set to true if map config is provided to panel");
+            panel.destroy();
+            
+        }
 
         function test_extent(t) {
             



More information about the Commits mailing list