[Commits] r462 - apps/opengeo/geoexplorer/trunk/lib

commits at geoext.org commits at geoext.org
Fri Apr 24 17:06:53 CEST 2009


Author: dwins
Date: 2009-04-24 17:06:53 +0200 (Fri, 24 Apr 2009)
New Revision: 462

Modified:
   apps/opengeo/geoexplorer/trunk/lib/GeoExplorer.js
Log:
Avoid showing popups when they would be empty (#157)


Modified: apps/opengeo/geoexplorer/trunk/lib/GeoExplorer.js
===================================================================
--- apps/opengeo/geoexplorer/trunk/lib/GeoExplorer.js	2009-04-24 05:58:58 UTC (rev 461)
+++ apps/opengeo/geoexplorer/trunk/lib/GeoExplorer.js	2009-04-24 15:06:53 UTC (rev 462)
@@ -787,11 +787,16 @@
             html = evt.text;
         }
 
+        if (html == '' || html.match(/<body>\s*<\/body>/) {
+            return;
+        }
+
         var lonlat = this.map.getLonLatFromPixel(evt.xy);
         var win = new GeoExt.Popup({
             html: html,
             title: "Feature Info",
             width: 250,
+            height: 300,
             lonlat: lonlat,
             autoScroll: true
         });



More information about the Commits mailing list