[Commits] r510 - in core/trunk/geoext: lib/GeoExt/data tests/lib/GeoExt/data

[commits at geoext.org]

Author: elemoine
Date: 2009-04-29 11:52:31 +0200 (Wed, 29 Apr 2009)
New Revision: 510

Modified:
   core/trunk/geoext/lib/GeoExt/data/FeatureStore.js
   core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html
Log:
FeatureStore.addFeaturesToLayer fails when there are no input records, r=fvanderbiest, p=fvanderbiest,me, r=me (closes #53)


Modified: core/trunk/geoext/lib/GeoExt/data/FeatureStore.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/data/FeatureStore.js	2009-04-29 03:14:57 UTC (rev 509)
+++ core/trunk/geoext/lib/GeoExt/data/FeatureStore.js	2009-04-29 09:52:31 UTC (rev 510)
@@ -299,8 +299,8 @@
                 }
             }
         } else {
-            features = new Array(len);
-            for(i=0, len=records.length; i<len; i++) {
+            features = new Array((len=records.length));
+            for(i=0; i<len; i++) {
                 features[i] = records[i].get("feature");
             }
         }

Modified: core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html
===================================================================
--- core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html	2009-04-29 03:14:57 UTC (rev 509)
+++ core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html	2009-04-29 09:52:31 UTC (rev 510)
@@ -28,7 +28,7 @@
         } 
 
         function test_load_clear(t) {
-            t.plan(5);
+            t.plan(7);
             
             var layer = new OpenLayers.Layer.Vector("Foo layer");
             var store = new GeoExt.data.FeatureStore({
@@ -56,6 +56,12 @@
             store.removeAll();
             t.eq(store.getCount(), 0, '"removeAll" on store removes all records from the store'); 
             t.eq(layer.features.length, 0, '"removeAll" on store removes features from layer'); 
+
+            // load no data
+            store.addRecordFilter = null;
+            store.loadData([]);
+            t.eq(store.getCount(), 0, '"loadData([]) does not add records to the store');
+            t.eq(layer.features.length, 0, '"loadData([]) does not add features to the layer');
         }
         
         function test_bind_unbind(t) {