[Commits] r1267 - in core/trunk/geoext: lib/GeoExt/widgets tests/lib/GeoExt/widgets

[commits at geoext.org]

Author: bartvde
Date: 2009-07-15 19:05:26 +0200 (Wed, 15 Jul 2009)
New Revision: 1267

Modified:
   core/trunk/geoext/lib/GeoExt/widgets/LegendPanel.js
   core/trunk/geoext/tests/lib/GeoExt/widgets/LegendPanel.html
Log:
fix minor javascript error in the legend panel when changing a non WMS layer, includes test case, thanks julien for the catch, non-functional change (closes #120)

Modified: core/trunk/geoext/lib/GeoExt/widgets/LegendPanel.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/widgets/LegendPanel.js	2009-07-15 16:36:22 UTC (rev 1266)
+++ core/trunk/geoext/lib/GeoExt/widgets/LegendPanel.js	2009-07-15 17:05:26 UTC (rev 1267)
@@ -136,7 +136,7 @@
         var layer = record.get('layer');
         var legend = this.getComponent(layer.id);
         if ((this.showTitle && !record.get('hideTitle')) && 
-            (legend.items.get(0).text !== record.get('title'))) {
+            (legend && legend.items.get(0).text !== record.get('title'))) {
                 // we need to update the title
                 legend.items.get(0).setText(record.get('title'));
         }

Modified: core/trunk/geoext/tests/lib/GeoExt/widgets/LegendPanel.html
===================================================================
--- core/trunk/geoext/tests/lib/GeoExt/widgets/LegendPanel.html	2009-07-15 16:36:22 UTC (rev 1266)
+++ core/trunk/geoext/tests/lib/GeoExt/widgets/LegendPanel.html	2009-07-15 17:05:26 UTC (rev 1267)
@@ -28,7 +28,7 @@
         }
 
         function test_legendurl(t) {
-            t.plan(1);
+            t.plan(2);
             var mapPanel = loadMapPanel();
             var lp  = new GeoExt.LegendPanel({
                 renderTo: 'legendpanel'});
@@ -41,6 +41,13 @@
             var url = item.items.get(1).items.get(0).getEl().dom.src;
             t.eq(url, newUrl, "Update the image with the provided legendURL");
 
+            var vectorLayer = new OpenLayers.Layer.Vector("vector layer");
+            mapPanel.map.addLayer(vectorLayer);
+
+            vectorLayer.setVisibility(false);
+
+            t.eq(lp.items.length, 1, "Currently there are no legends for non WMS layers");
+
             lp.destroy();
             mapPanel.destroy();
         }