[Commits] r1297 - core/trunk/geoext/lib/GeoExt/data

[commits at geoext.org]

Author: tschaub
Date: 2009-07-29 16:57:11 +0200 (Wed, 29 Jul 2009)
New Revision: 1297

Modified:
   core/trunk/geoext/lib/GeoExt/data/FeatureStore.js
Log:
Setting the feature directly on the record's data object.  This avoids infinite recursion in Ext 3.0.  For the next release, we will likely replace this with record.setFeature (see #133).  r=ahocevar (closes #134)

Modified: core/trunk/geoext/lib/GeoExt/data/FeatureStore.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/data/FeatureStore.js	2009-07-29 14:34:26 UTC (rev 1296)
+++ core/trunk/geoext/lib/GeoExt/data/FeatureStore.js	2009-07-29 14:57:11 UTC (rev 1297)
@@ -261,7 +261,9 @@
                 // endEdit
                 record.set("state", feature.state);
                 record.set("fid", feature.fid);
-                record.set("feature", feature);
+                // Ext 3.0 does not allow circular references in objects passed
+                // to record.set
+                record.data["feature"] = feature;
                 this._updating = true;
                 record.endEdit();
                 delete this._updating;