[Commits] r1522 - in sandbox/cmoullet/ux/StreetViewPanel: examples ux/widgets

[commits at geoext.org]

Author: cmoullet
Date: 2009-11-30 07:51:55 +0100 (Mon, 30 Nov 2009)
New Revision: 1522

Modified:
   sandbox/cmoullet/ux/StreetViewPanel/examples/StreetViewPanelExample.js
   sandbox/cmoullet/ux/StreetViewPanel/ux/widgets/StreetViewPanel.js
Log:
Fix IE and jslintification of the code (quite happy of the result ;-)


Modified: sandbox/cmoullet/ux/StreetViewPanel/examples/StreetViewPanelExample.js
===================================================================
--- sandbox/cmoullet/ux/StreetViewPanel/examples/StreetViewPanelExample.js	2009-11-29 14:38:57 UTC (rev 1521)
+++ sandbox/cmoullet/ux/StreetViewPanel/examples/StreetViewPanelExample.js	2009-11-30 06:51:55 UTC (rev 1522)
@@ -21,7 +21,7 @@
     };
 
     layer = new OpenLayers.Layer.Google(
-            "Google Street", {sphericalMercator: true}, {isBaseLayer: true, buffer: 1});
+            "Google Street", {sphericalMercator: true});
 
     var map = new OpenLayers.Map(options);
 
@@ -44,12 +44,14 @@
                         layer.mapObject.addOverlay(new GStreetviewOverlay());
                         streetViewPanel.add(streetViewPanelItem);
                         streetViewPanel.setSize('50%', 0);
+                        streetViewPanel.setVisible(true);
                         streetViewPanel.doLayout();
                         viewport.doLayout();
                     } else {
                         layer.mapObject.clearOverlays();
                         streetViewPanel.remove('streetViewPanelItem');
-                        streetViewPanel.setSize(0, 0);
+                        streetViewPanel.setWidth(0);
+                        streetViewPanel.setVisible(false);
                         streetViewPanel.doLayout();
                         viewport.doLayout();
                     }
@@ -75,7 +77,7 @@
         videoMode: true,
         showLinks: true,
         showTool: true
-    }
+    };
 
     viewport = new Ext.Viewport({
         layout: "border",
@@ -95,6 +97,7 @@
             {
                 region: "east",
                 layout: 'fit',
+                width: '50%',
                 id: "streetviewpanel",
                 title: 'Street View Panel',
                 closeAction: 'hide',
@@ -113,10 +116,8 @@
 
     mapPanel = Ext.getCmp("mappanel");
     streetViewPanel = Ext.getCmp("streetviewpanel");
-    viewport.doLayout();
     layer.mapObject.addOverlay(new GStreetviewOverlay());
     streetViewPanel.add(streetViewPanelItem);
-    streetViewPanel.setSize('50%', 0);
     streetViewPanel.doLayout();
     viewport.doLayout();
 

Modified: sandbox/cmoullet/ux/StreetViewPanel/ux/widgets/StreetViewPanel.js
===================================================================
--- sandbox/cmoullet/ux/StreetViewPanel/ux/widgets/StreetViewPanel.js	2009-11-29 14:38:57 UTC (rev 1521)
+++ sandbox/cmoullet/ux/StreetViewPanel/ux/widgets/StreetViewPanel.js	2009-11-30 06:51:55 UTC (rev 1522)
@@ -332,7 +332,7 @@
                     this.deleteFeatures();
                     alert(OpenLayers.i18n('Google Street View: No panorama found near this position. You have to click elsewhere ;-)'));
                 } else if (data.code == 500) {
-                    this.deleteFeatures()
+                    this.deleteFeatures();
                     alert(OpenLayers.i18n('Google Street View: Server error'));
                 } else if (data.code == 200) {
                     // Add the navigation tool
@@ -440,7 +440,7 @@
                                     this.streetviewclient.getPanoramaById(feature.attributes.panoId, this.panorama.callback.createDelegate(this));
                                     this.panorama.videoReady = false;
                                 }
-                            }
+                            };
                             // Manage the start and stop of the video
                             if (!this.panorama.videoPlay) {
                                 //console.log("Start Play Video");
@@ -480,12 +480,12 @@
             }
             if (parameters.zoom) {
                 if (this.map) {
-                    this.map.zoomTo(parseInt(parameters.zoom));
+                    this.map.zoomTo(parseInt(parameters.zoom,10));
                 }
             }
             this.panorama.yaw = parseFloat(parameters.yaw);
             this.panorama.pitch = parseFloat(parameters.pitch);
-            this.panorama.zoom = parseInt(parameters.panoZoom);
+            this.panorama.zoom = parseInt(parameters.panoZoom, 10);
             this.panorama.clickMode = parameters.clickMode;
             this.panorama.videoTimeInterval = parameters.videoTimeInterval;
             this.panorama.showTool = parameters.showTool;