[Commits] r1898 - in core/trunk/geoext: lib/overrides tests/lib/overrides

Sat Feb 13 12:40:20 CET 2010

Author: bartvde
Date: 2010-02-13 12:40:20 +0100 (Sat, 13 Feb 2010)
New Revision: 1898

Modified:
   core/trunk/geoext/lib/overrides/override-ext-ajax.js
   core/trunk/geoext/tests/lib/overrides/override-ext-ajax.html
Log:
Making sure form submit succeeds as well with override-ext-ajax.js, r=elemoine (closes #170)

Modified: core/trunk/geoext/lib/overrides/override-ext-ajax.js
===================================================================

--- core/trunk/geoext/lib/overrides/override-ext-ajax.js	2010-02-12 21:24:55 UTC (rev 1897)
+++ core/trunk/geoext/lib/overrides/override-ext-ajax.js	2010-02-13 11:40:20 UTC (rev 1898)
@@ -48,8 +48,8 @@
                 data = typeof options.jsonData == "object" ?
                        Ext.encode(options.jsonData) : options.jsonData;
             }
-            // options.params means form-encoded data, so change content-type
-            if (options.params && (!hs || !hs["Content-Type"])) {
+            // options.form or options.params means form-encoded data, so change content-type
+            if ((options.form || options.params) && (!hs || !hs["Content-Type"])) {
                 hs = hs || {};
                 hs["Content-Type"] = "application/x-www-form-urlencoded";
             }

Modified: core/trunk/geoext/tests/lib/overrides/override-ext-ajax.html
===================================================================
--- core/trunk/geoext/tests/lib/overrides/override-ext-ajax.html	2010-02-12 21:24:55 UTC (rev 1897)
+++ core/trunk/geoext/tests/lib/overrides/override-ext-ajax.html	2010-02-13 11:40:20 UTC (rev 1898)
@@ -160,7 +160,7 @@
         }
 
         function test_formPost(t) {
-            t.plan(1);
+            t.plan(2);
             var proto = OpenLayers.Request.XMLHttpRequest.prototype;
             proto.setRequestHeader = function(k, v) {
                 t.ok(k == "Content-Type" && v == "application/x-www-form-urlencoded",
@@ -173,9 +173,15 @@
                 params: { username: 'bart', password: 'xx'},
                 url: 'foo.php'
             });
+
+            var form = new Ext.form.FormPanel();
+            form.add(new Ext.form.Hidden({name: 'foo', value: 'bar'}));
+            form.render('basicform');
+            form.getForm().submit({method: 'POST', url: 'foo.php'});
         }
     </script>
   <body>
+  <div id="basicform"></div>
   <form id="form">
       <input type="text" name="key1" value="val1"></input>
       <input type="checkbox" name="key2" value="val2" checked="checked"></input>

