[Commits] r1800 - sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data

commits at geoext.org commits at geoext.org
Thu Jan 21 20:42:46 CET 2010


Author: ahocevar
Date: 2010-01-21 20:42:46 +0100 (Thu, 21 Jan 2010)
New Revision: 1800

Modified:
   sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintPage.js
   sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintProvider.js
Log:
some modifications as proposed in Bart's review.

Modified: sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintPage.js
===================================================================
--- sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintPage.js	2010-01-21 19:34:01 UTC (rev 1799)
+++ sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintPage.js	2010-01-21 19:42:46 UTC (rev 1800)
@@ -338,9 +338,9 @@
     /** private: method[calculatePageBounds]
      *  :param scale: ``Ext.data.Record`` Scale record to calculate the page
      *      bounds for.
-     *  :param units: ``String`` map units to use for the scale calculation.
-     *      Optional if a ``layer`` that is added to a map was configured. If
-     *      neither is provided, "dd" will be assumed.
+     *  :param units: ``String`` Map units to use for the scale calculation.
+     *      Optional if ``feature`` is added to layer which is added to a
+     *      map. If not provided, "dd" will be assumed.
      *  :return: ``OpenLayers.Bounds``
      *  
      *  Calculates the page bounds for a given scale.

Modified: sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintProvider.js
===================================================================
--- sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintProvider.js	2010-01-21 19:34:01 UTC (rev 1799)
+++ sandbox/ahocevar/playground/trunk/geoext/lib/GeoExt/data/PrintProvider.js	2010-01-21 19:42:46 UTC (rev 1800)
@@ -144,7 +144,7 @@
     layouts: null,
     
     /** api: property[dpi]
-     *  ``Ext.data.Record`` the record for the currently used layout.
+     *  ``Ext.data.Record`` the record for the currently used resolution.
      *  Read-only, use :ref:`GeoExt.data.PrintProvider.setDpi` to set the
      *  value.
      */
@@ -268,7 +268,7 @@
     },
     
     /** api: method[setDpi]
-     *  :param layout: ``Ext.data.Record`` the dpi record.
+     *  :param dpi: ``Ext.data.Record`` the dpi record.
      *  
      *  Sets the dpi for this printProvider.
      */
@@ -283,9 +283,9 @@
      *      :class:`GeoExt.data.PrintPage` page(s) to print.
      *  :param options: ``Object`` of additional options:
      *      * ``legend``: :class:`GeoExt.LegendPanel` If provided, the legend
-     *        will be added to the print document. For this to look like in
-     *        the MapPanel, the following settings in the ``!legends`` block
-     *        of the print module are recommended:
+     *        will be added to the print document. For the printed result to
+     *        look like the LegendPanel, the following settings in the
+     *        ``!legends`` block of the print module are recommended:
      *        
      *        .. code-block:: none
      *        



More information about the Commits mailing list