[Commits] r2237 - in core/trunk/geoext/lib/GeoExt: data plugins

[commits at geoext.org]

Author: ahocevar
Date: 2010-07-05 14:06:24 +0200 (Mon, 05 Jul 2010)
New Revision: 2237

Modified:
   core/trunk/geoext/lib/GeoExt/data/PrintPage.js
   core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js
Log:
Make PrintPage handle layout changes correctly so PrintExtent does not need to know about layout changes any more. r=bartvde (closes #294)


Modified: core/trunk/geoext/lib/GeoExt/data/PrintPage.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/data/PrintPage.js	2010-07-02 15:15:31 UTC (rev 2236)
+++ core/trunk/geoext/lib/GeoExt/data/PrintPage.js	2010-07-05 12:06:24 UTC (rev 2237)
@@ -207,11 +207,11 @@
      */
     updateFeature: function(geometry, mods) {
         var f = this.feature;
+        var modified = f.geometry !== geometry;
         geometry.id = f.geometry.id;
         f.geometry = geometry;
         
         if(!this._updating) {
-            var modified = false;
             for(var property in mods) {
                 if(mods[property] === this[property]) {
                     delete mods[property];

Modified: core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js	2010-07-02 15:15:31 UTC (rev 2236)
+++ core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js	2010-07-05 12:06:24 UTC (rev 2237)
@@ -234,8 +234,6 @@
         this.map.addLayer(this.layer);
         this.map.addControl(this.control);
         this.control.activate();
-
-        this.printProvider.on("layoutchange", this.updateBox, this);
     },
 
     /** private: method[tearDown]
@@ -250,8 +248,6 @@
         // We use obj.events to test whether an OpenLayers object is
         // destroyed or not.
 
-        this.printProvider.un("layoutchange", this.updateBox, this);
-
         var map = this.map;
 
         var control = this.control;