[Commits] r2430 - core/trunk/geoext/lib/GeoExt/widgets

commits at geoext.org commits at geoext.org
Wed Oct 6 13:22:54 CEST 2010


Author: bartvde
Date: 2010-10-06 13:22:53 +0200 (Wed, 06 Oct 2010)
New Revision: 2430

Modified:
   core/trunk/geoext/lib/GeoExt/widgets/LayerOpacitySlider.js
   core/trunk/geoext/lib/GeoExt/widgets/ZoomSlider.js
Log:
the unbind functions of ZoomSlider and LayerOpacitySlider are not totally safe, r=fredj (closes #357)

Modified: core/trunk/geoext/lib/GeoExt/widgets/LayerOpacitySlider.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/widgets/LayerOpacitySlider.js	2010-10-06 09:10:43 UTC (rev 2429)
+++ core/trunk/geoext/lib/GeoExt/widgets/LayerOpacitySlider.js	2010-10-06 11:22:53 UTC (rev 2430)
@@ -172,7 +172,7 @@
     /** private: method[unbind]
      */
     unbind: function() {
-        if (this.layer && this.layer.map) {
+        if (this.layer && this.layer.map && this.layer.map.events) {
             this.layer.map.events.un({
                 changelayer: this.update,
                 scope: this

Modified: core/trunk/geoext/lib/GeoExt/widgets/ZoomSlider.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/widgets/ZoomSlider.js	2010-10-06 09:10:43 UTC (rev 2429)
+++ core/trunk/geoext/lib/GeoExt/widgets/ZoomSlider.js	2010-10-06 11:22:53 UTC (rev 2430)
@@ -189,7 +189,7 @@
     /** private: method[unbind]
      */
     unbind: function() {
-        if(this.map) {
+        if(this.map && this.map.events) {
             this.map.events.un({
                 zoomend: this.update,
                 changebaselayer: this.initZoomValues,



More information about the Commits mailing list