[Commits] r2765 - sandbox/gxm/geoext/gxm/lib/GXM/widgets

[commits at geoext.org]

Author: marcjansen
Date: 2011-07-20 17:05:32 +0200 (Wed, 20 Jul 2011)
New Revision: 2765

Modified:
   sandbox/gxm/geoext/gxm/lib/GXM/widgets/MapPanel.js
Log:
[gxm] integrate review comments

Modified: sandbox/gxm/geoext/gxm/lib/GXM/widgets/MapPanel.js
===================================================================
--- sandbox/gxm/geoext/gxm/lib/GXM/widgets/MapPanel.js	2011-07-20 14:25:21 UTC (rev 2764)
+++ sandbox/gxm/geoext/gxm/lib/GXM/widgets/MapPanel.js	2011-07-20 15:05:32 UTC (rev 2765)
@@ -23,7 +23,10 @@
     bounds: null,
     //TODO: do we really wish to have this fullscreen?
     //TODO: is this in any case a usefull default?
-    fullscreen: true, 
+    fullscreen: true,
+    // set monitorResize to true just as the original Map-component of 
+    // Sencha Touch does (Review BvdE).
+    // monitorResize: true,
     getDefaultControls: function() {
         return [
             new OpenLayers.Control.TouchNavigation(),
@@ -31,8 +34,10 @@
         ];   
     },
     initComponent: function(){
+        // set scroll to false just as the original Map-component of 
+        // Sencha Touch does (Review BvdE).
+        //this.scroll = false;
         
-        
         // check config-property map for an existing OpenLayers.Map-instance, a
         // conf object for an OpenLayers.Map or null
         if ( !(this.map instanceof OpenLayers.Map) ) {
@@ -191,7 +196,15 @@
 		
         this.fireEvent("afterlayerremove");
     },
-      
+    
+    // @private    
+    onRender : function(container, position) {
+        // set setVisibilityMode to Ext.Element.OFFSETS just as the 
+        // original Map-component of Sencha Touch does (Review BvdE).
+        GXM.MapPanel.superclass.onRender.apply(this, arguments);
+        this.el.setVisibilityMode(Ext.Element.OFFSETS);        
+    },
+    
     afterRender: function(){
         GXM.MapPanel.superclass.afterRender.apply(this, arguments);
         var me = this;
@@ -209,6 +222,7 @@
             });
         }
     },
+    
     renderMap: function(){
         var me = this;
         var map = me.map;