[Commits] r2637 - core/trunk/geoext/lib

commits at geoext.org commits at geoext.org
Thu Mar 24 21:17:23 CET 2011


Author: tschaub
Date: 2011-03-24 21:17:23 +0100 (Thu, 24 Mar 2011)
New Revision: 2637

Modified:
   core/trunk/geoext/lib/GeoExt.js
Log:
Making it so the debug loader always uses document.write to append scripts.  This makes the loader work in Firefox 4. r=ahocevar (closes #414)

Modified: core/trunk/geoext/lib/GeoExt.js
===================================================================
--- core/trunk/geoext/lib/GeoExt.js	2011-03-24 18:42:49 UTC (rev 2636)
+++ core/trunk/geoext/lib/GeoExt.js	2011-03-24 20:17:23 UTC (rev 2637)
@@ -124,27 +124,12 @@
             "GeoExt/Lang.js"
         );
 
-        var agent = navigator.userAgent;
-        var docWrite = (agent.match("MSIE") || agent.match("Safari"));
-        if(docWrite) {
-            var allScriptTags = new Array(jsfiles.length);
-        }
+        var len = jsfiles.length;
+        var allScriptTags = new Array(len);
         var host = getScriptLocation() + "lib/";    
-        for (var i=0, len=jsfiles.length; i<len; i++) {
-            if (docWrite) {
-                allScriptTags[i] = "<script src='" + host + jsfiles[i] +
-                                   "'></script>"; 
-            } else {
-                var s = document.createElement("script");
-                s.src = host + jsfiles[i];
-                var h = document.getElementsByTagName("head").length ? 
-                           document.getElementsByTagName("head")[0] : 
-                           document.body;
-                h.appendChild(s);
-            }
+        for (var i=0; i<len; i++) {
+            allScriptTags[i] = "<script src='" + host + jsfiles[i] +"'></script>"; 
         }
-        if (docWrite) {
-            document.write(allScriptTags.join(""));
-        }
+        document.write(allScriptTags.join(""));
     }
 })();



More information about the Commits mailing list