[Commits] r2859 - in core/trunk/geoext: lib/GeoExt/plugins tests/lib/GeoExt/plugins

commits at geoext.org commits at geoext.org
Tue Oct 25 09:20:45 CEST 2011


Author: fredj
Date: 2011-10-25 09:20:45 +0200 (Tue, 25 Oct 2011)
New Revision: 2859

Modified:
   core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js
   core/trunk/geoext/tests/lib/GeoExt/plugins/PrintExtent.html
Log:
PrintExtent: remove the layer vector in hide function. r=elemoine (closes #444)

Modified: core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js
===================================================================
--- core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js	2011-10-20 09:57:01 UTC (rev 2858)
+++ core/trunk/geoext/lib/GeoExt/plugins/PrintExtent.js	2011-10-25 07:20:45 UTC (rev 2859)
@@ -256,9 +256,8 @@
         // We use obj.events to test whether an OpenLayers object is
         // destroyed or not.
 
-        var map = this.map;
+        var map = this.map, layer = this.layer, control = this.control;
 
-        var control = this.control;
         if(control && control.events) {
             control.deactivate();
             if(map && map.events && control.map) {
@@ -266,11 +265,7 @@
             }
         }
 
-        var layer = this.layer;
-
-        if(!this.initialConfig.layer &&
-           map && map.events &&
-           layer && layer.map) {
+        if(map && map.events && layer && layer.map) {
             map.removeLayer(layer);
         }
     },

Modified: core/trunk/geoext/tests/lib/GeoExt/plugins/PrintExtent.html
===================================================================
--- core/trunk/geoext/tests/lib/GeoExt/plugins/PrintExtent.html	2011-10-20 09:57:01 UTC (rev 2858)
+++ core/trunk/geoext/tests/lib/GeoExt/plugins/PrintExtent.html	2011-10-25 07:20:45 UTC (rev 2859)
@@ -119,6 +119,7 @@
             t.plan(2);
  
             var printExtent = new GeoExt.plugins.PrintExtent({
+                layer: new OpenLayers.Layer.Vector("hello world"),
                 printProvider: new GeoExt.data.PrintProvider({
                     capabilities: printCapabilities
                 })



More information about the Commits mailing list