[Commits] r2863 - in core/trunk/geoext: lib/GeoExt/data tests/lib/GeoExt/data

Thu Oct 27 15:33:49 CEST 2011

Author: bartvde
Date: 2011-10-27 15:33:48 +0200 (Thu, 27 Oct 2011)
New Revision: 2863

Modified:
   core/trunk/geoext/lib/GeoExt/data/FeatureStore.js
   core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html
Log:
FeatureStore could use a destroy method that unbinds the layer, r=ahocevar (closes #367)

Modified: core/trunk/geoext/lib/GeoExt/data/FeatureStore.js
===================================================================

--- core/trunk/geoext/lib/GeoExt/data/FeatureStore.js	2011-10-26 08:36:57 UTC (rev 2862)
+++ core/trunk/geoext/lib/GeoExt/data/FeatureStore.js	2011-10-27 13:33:48 UTC (rev 2863)
@@ -420,7 +420,15 @@
                     }
                 }
             }
+        },
+
+        /** private: method[destroy]
+         */
+        destroy: function() {
+            this.unbind();
+            GeoExt.data.FeatureStore.superclass.destroy.call(this);
         }
+
     };
 };
 

Modified: core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html
===================================================================
--- core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html	2011-10-26 08:36:57 UTC (rev 2862)
+++ core/trunk/geoext/tests/lib/GeoExt/data/FeatureStore.html	2011-10-27 13:33:48 UTC (rev 2863)
@@ -330,6 +330,18 @@
             t.ok(ok, "modifying filtered out features does not cause errors");
 
         }
+
+        function test_destroy(t) {
+            t.plan(1);
+
+            var layer = new OpenLayers.Layer.Vector("Foo layer");
+            var store = new GeoExt.data.FeatureStore({
+                layer: layer
+            });
+
+            store.destroy();
+            t.eq(store.layer, null, "Destroy calls unbind");
+        }
     </script> 
  
   <body> 

